[monit_syncd][bfn] Use correct syncd launch parameters in monit_syncd #4029
Conversation
Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>
|
@yxieca Please review this. |
|
If this is the right argument string on BF platform. By all means go ahead. I am curious why you put sai.profile under /tmp/? Can you follow other platform's sample to mount device folder to syncd. If the sai.profile is generated by a template, please follow https://github.com/Azure/sonic-buildimage/blob/master/platform/broadcom/docker-syncd-brcm/start.sh#L45 to put it to a consistent place. If you need to adjust sai.profile location, please start anther PR. This comment doesn't mean to ask you to change it in this PR. |
|
I will submit a PR to fix the name of syncd process in the monit config file. |
|
I suggest we close this PR in favor of #4033, in which we do not check for any parameters. This solution will be more future-proof, in that if any parameters change, we will not need to make any updates here. |
Signed-off-by: Vitaliy Senchyshyn vsenchyshyn@barefootnetworks.com
- What I did
Fixed launch parameters in monit_syncd for BFN platform so now error log about syncd not running do0esn't wrognly appear when syncd is up.
- How I did it
- How to verify it
Run SONiC on BFN box and verify there is no "'syncd' process is not running" error log when syncd is up and running
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)